• src/sbbs3/ars.c

    From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Sun Jun 11 14:33:40 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/f9acb79dec8930f45cd3d2dc
    Modified Files:
    src/sbbs3/ars.c
    Log Message:
    Fix unaligned memory accesses as reported by ASan

    e.g. runtime error: store to misaligned address 0x7ffec33195e3 for type
    'short int', which requires 2 byte alignment

    These aren't a problem for x86, but could be a problem for some other CPU architectures that don't support unaligned access. I didn't use memcpy() to resolve this (though that would've worked) to make this change endian agnostic.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Jan 11 16:11:34 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/f28907e3126cb76da58195b0
    Modified Files:
    src/sbbs3/ars.c
    Log Message:
    Fix the auto-keyword detection based on parameter type for USER, DIR, and SUB

    SUB and DIR have long had this bug, but I just noticed while playing with the new USER keyword capabilities (specifying user numbers and/or names).

    If you switched between numeric and alpha/string parameters, without restating the ARS keyword, the keyword would could end up wrong in the parsed byte array.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net