• src/sftp/sftp_attr.c

    From Deuc¿@VERT to Git commit to main/sbbs/master on Thu Dec 28 01:26:02 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/e20fc4eb3532f004856291ee
    Added Files:
    src/sftp/sftp_attr.c
    Log Message:
    Add missing sftp_attr.c


    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Wed Jan 1 22:43:29 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/13e8739cb615b294bf243988
    Modified Files:
    src/sftp/sftp_attr.c
    Log Message:
    Another Coverity "fix"...

    This is kinda valid... I am reading a 32-bit integer from a socket,
    then trying to loop that many times. What Coverity didn't notice
    though is that the loop will exit way before due to the buffer
    being exhausted.

    By ensuring that it's less than UINT32_MAX/4, I'm still not really
    enforcing anything since with the 32-bit value for extcnt, and a
    32-bit value for every string, there could only be strings before
    it failed anyway, even with a 4GB buffer (which you couldn't do).

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net